Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cl: loadVars check recover #1372

Merged
merged 3 commits into from
Jun 4, 2023
Merged

cl: loadVars check recover #1372

merged 3 commits into from
Jun 4, 2023

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented May 29, 2023

fix #1369 , loadVars check recover and resetInit

func set(name string, v int) string {
	return name
}

func test() {
	var a = set("box")  // dump error
	println(a)
}

gop run can dump error info

./main.gop:6:10: too few arguments in call to set("box")
	have (untyped string)
	want (name string, v int)
./main.gop:7:10: undefined: a

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f8574ec) 90.21% compared to head (1aaf0f9) 90.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          24       24           
  Lines        9132     9137    +5     
=======================================
+ Hits         8238     8243    +5     
  Misses        727      727           
  Partials      167      167           
Impacted Files Coverage Δ
cl/compile.go 97.78% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xushiwei xushiwei merged commit ff2f7ea into goplus:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not print complie error line in func
3 participants