Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix style issues #117

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fix: fix style issues #117

merged 3 commits into from
Feb 6, 2024

Conversation

Kasey0727
Copy link
Contributor

@Kasey0727 Kasey0727 commented Feb 6, 2024 •
edited
Loading

  1. home_yap.html:
    • modify header style
    • add exit for signing out
    • please continue to complete integration testing (including search, sign out) @Baihhh
  2. article_yap.html:
    • modify qrcode style
    • add href to breadcrumb
    • please continue to complete integration testing (including article's info, author's info) @Baihhh
    • After the header of home_yap.html is completed, replace the header in article_yap.html when splitting web into components.

IRONICBo
IRONICBo approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IRONICBo IRONICBo merged commit 50bf6df into goplus:dev Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IRONICBo IRONICBo IRONICBo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kasey0727 @IRONICBo