Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the article share #108

Merged
merged 7 commits into from
Feb 7, 2024
Merged

feat: add the article share #108

merged 7 commits into from
Feb 7, 2024

Conversation

xhyqaq
Copy link
Contributor

@xhyqaq xhyqaq commented Feb 5, 2024

No description provided.

@xhyqaq
Copy link
Contributor Author

xhyqaq commented Feb 5, 2024

@IRONICBo CR

IRONICBo
IRONICBo requested changes Feb 5, 2024
View reviewed changes
internal/core/community.go Outdated
}

if userId == "" {
userId = "游客"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhyqaq Please use english, and do not set userId to string.

@IRONICBo IRONICBo added bug Something isn't working WIP and removed bug Something isn't working labels Feb 6, 2024
@qiniu-x qiniu-x
Copy link

qiniu-x bot commented Feb 7, 2024

[Git-flow] Hi @xhyqaq, There are some suggestions for your information:

Rebase suggestions

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

IRONICBo
IRONICBo approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IRONICBo IRONICBo merged commit aa6f228 into goplus:dev Feb 7, 2024
1 check passed
@xhyqaq xhyqaq deleted the feat/article-share branch February 20, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IRONICBo IRONICBo IRONICBo approved these changes

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhyqaq @IRONICBo