Skip to content

Commit

Permalink
Do not print error on List::remove() if can't find a value
Browse files Browse the repository at this point in the history
For consistency with godotengine/godot#34028.

Note that `erase` was renamed to `remove` in Goost.
  • Loading branch information
Xrayez committed Sep 13, 2020
1 parent b7285ae commit 9168397
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/types/list.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ void LinkedList::pop_front() {
}

bool LinkedList::remove(ListElement *p_I) {
if (_data) {
if (_data && p_I) {
bool ret = _data->erase(p_I);
if (_data->size_cache == 0) {
memdelete(_data);
Expand Down

0 comments on commit 9168397

Please sign in to comment.