Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin Flow: cameraMoveStartedEvents missing reason #168

Closed
newmanw opened this issue Nov 24, 2021 · 2 comments · Fixed by #169
Closed

Kotlin Flow: cameraMoveStartedEvents missing reason #168

newmanw opened this issue Nov 24, 2021 · 2 comments · Fixed by #169
Assignees
@barbeau
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@newmanw
Copy link

newmanw commented Nov 24, 2021 •
edited
Loading

Environment details

OS type and version: any
Library version and other environment information: v3.2.0

Steps to reproduce

googleMap.cameraMoveStartedEvents().collect { ... }

Code example

cameraMoveStartedEvents does not pass reason code:

https://github.com/googlemaps/android-maps-ktx/blob/main/maps-ktx/src/main/java/com/google/maps/android/ktx/GoogleMap.kt#L240

Should be:

public fun GoogleMap.cameraMoveStartedEvents(): Flow<Int> =
    callbackFlow {
        setOnCameraMoveStartedListener {
            trySend(it)
        }
        awaitClose {
            setOnCameraMoveStartedListener(null)
        }
    }
@newmanw newmanw added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 24, 2021
@barbeau barbeau assigned barbeau and unassigned arriolac Dec 1, 2021
barbeau added a commit that referenced this issue Dec 1, 2021
@barbeau
fix: Add missing reason for cameraMoveStartedEvents() flow
c28a695 
Also add it to the demo app

Closes #168
@barbeau barbeau mentioned this issue Dec 1, 2021
Merged
4 tasks
@barbeau
Copy link
Contributor

barbeau commented Dec 1, 2021

@newmanw Thanks for flagging this! I've opened PR #169 which should fix this.

@barbeau barbeau added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Dec 1, 2021
arriolac pushed a commit that referenced this issue Dec 1, 2021
@barbeau
fix: Add missing reason for cameraMoveStartedEvents() flow (#169)
2166001 
Also add it to the demo app

Closes #168
googlemaps-bot pushed a commit that referenced this issue Dec 1, 2021
@semantic-release-bot
chore(release): 3.2.1 [skip ci]
2f25538 
## [3.2.1](v3.2.0...v3.2.1) (2021-12-01)

### Bug Fixes

* Add missing reason for cameraMoveStartedEvents() flow ([#169](#169)) ([2166001](2166001)), closes [#168](#168)
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barbeau barbeau

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add missing reason for cameraMoveStartedEvents() flow googlemaps/android-maps-ktx
4 participants
@arriolac @barbeau @newmanw @googlemaps-bot