Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add and use the secrets plugin in the snippets #633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add and use the secrets plugin in the snippets #633

wants to merge 2 commits into from

Conversation

dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Dec 24, 2023 •
edited
Loading

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/316599621 🦕

wangela
wangela requested changes Jan 18, 2024
View reviewed changes
snippets/local.defaults.properties Show resolved Hide resolved
snippets/local.defaults.properties Outdated Show resolved Hide resolved
snippets/app/build.gradle Outdated Show resolved Hide resolved
@dkhawk dkhawk requested a review from wangela February 6, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela Awaiting requested review from wangela

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkhawk @wangela