-
Notifications
You must be signed in to change notification settings - Fork 31
Adding classes to assist with streaming from gRPC #99
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This is very exciting! Will there be gRPC for Annotations too? |
Hi Paul, Not quite yet, we're waiting to see how the GA4GH discussions regarding an On Wed, Jun 17, 2015 at 11:25 AM, Paul Grosu [email protected]
|
Hi Dion, I definitely would not wait too long - actually I would not wait at all. It would definitely be better to just implement one or more proof-of-concept(s) to show their pro/cons, and then tweak them afterwards to GA4GH's preference. Things usually move faster that way, and then people have ideas to play with which are actually applied. I'm not sure everyone there has the resources and wealth of ideas you would be exposed to at Google. This would be a great leadership opportunity to expand people's minds on how to think differently and/or bigger. Paul |
Ok, this should be good to merge now that I was able to update the utils-java version in the pom file. |
LGTM! Thanks! On Fri, Jun 19, 2015 at 2:01 PM, Careyjmac [email protected] wrote:
|
Adding classes to assist with streaming from gRPC
* This step exists to emit the individual reads in a parallel step to the StreamReads step in | ||
* order to increase throughput. | ||
*/ | ||
private static class ConvergeReadsList extends DoFn<List<Read>, Read> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit (and please feel free to ignore): the function name ConvergeReadsList
did not convey the function's purpose to me at first glance. I looked up the dictionary definition for "converge" and perhaps it is appropriate in this case because the scenario is many lists coming together as a collection of individual reads?
Alternative names could be ConvertReadsListToReads or EmitIndividualReads.
@Careyjmac these helper classes are great! Other than my minor comments, this LGTM. |
Adding classes to assist with streaming from gRPC
Please do not merge just yet, waiting on an update to the utils-java dependency that fixes a bug in gRPC that should make this work successfully on larger datasets.