Locally listen on IPv4 and IPv6 addresses #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Implemented the `DualStackLocalSocket` as a small newtype for IPv6 sockets that are configured to be able to send and receive ipv6 and ipv4 traffic on all platforms for the locally listening socket. Updated the code base and docs and fixed several issues that existed for handling IPv6 addresses in the code base, including updates to the Firewall filter to be able to better manage ipv4 + ipv6 combo rule sets. Updated the `test_utils` framework to provide coverage in tests for both ipv4 and ipv6 by allowing for either an IPv4 or IPv6 address to be created from the framework. Closes googleforgames#666
markmandel
force-pushed
the
feature/ipv6nv4_nope_ipv6
branch
from
fd83083
to
d18516c
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: d6c6eb52-b179-4df3-86a6-ff81fab33b89 The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Implemented the
DualStackLocalSocketas a small newtype for IPv6 sockets that are configured to be able to send and receive ipv6 and ipv4 traffic on all platforms for the locally listening socket.Updated the code base and docs and fixed several issues that existed for handling IPv6 addresses in the code base, including updates to the Firewall filter to be able to better manage ipv4 + ipv6 combo rule sets.
Which issue(s) this PR fixes:
Closes #666
Special notes for your reviewer:
Updated the
test_utilsframework to provide coverage in tests for both ipv4 and ipv6 by allowing for either an IPv4 or IPv6 address to be created from the framework.