Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Unreal Engine Plugin #778

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Update Unreal Engine Plugin #778

merged 5 commits into from
Feb 27, 2024

Conversation

XAMPPRocky
Copy link
Collaborator

This PR updates the unreal engine plugin with support for QCMP, and continually measuring endpoint latency in the background, enabling client's to get their lowest latency endpoint to them for matchmaking.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@XAMPPRocky
Copy link
Collaborator Author

CI failure is unrelated.

@markmandel
Copy link
Member

CI failure is unrelated.

Yeah having a look at the issue now. I think an upgrade of trust-dns-resolver will resolve it.

@markmandel
Copy link
Member

Yeah having a look at the issue now. I think an upgrade of trust-dns-resolver will resolve it.

And confirmed, but they broke their API, so just resolving it now.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel
markmandel reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust y'alls experience with Unreal way more than any ideas I have 😁

LGTM, just a suggestion on the docs, and some missing header licences.

sdks/ue5/README.md Outdated Show resolved Hide resolved
sdks/ue5/Source/Quilkin/Quilkin.build.cs Outdated Show resolved Hide resolved
sdks/ue5/Source/Quilkin/Public/QuilkinSettings.h Outdated Show resolved Hide resolved
sdks/ue5/Source/Quilkin/Private/Tests/QuilkinControlMessageProtocolTest.cpp Outdated Show resolved Hide resolved
sdks/ue5/Source/Quilkin/Private/QuilkinSettings.cpp Outdated Show resolved Hide resolved
sdks/ue5/Source/Quilkin/Private/QuilkinInternetAddrs.h Outdated Show resolved Hide resolved
sdks/ue5/Source/Quilkin/Private/QuilkinInternetAddrs.cpp Outdated Show resolved Hide resolved
@markmandel
Copy link
Member

Just bumping that this needs some licences and some readme fixes, and otherwise it's good to merge.

@markmandel
Copy link
Member

Just checking in to see if there is anything upstream that's blocking this from getting fixed up and merged?

@XAMPPRocky
Copy link
Collaborator Author

No I just haven't had the time to address the feedback yet.

@markmandel
Copy link
Member

No worries - just wanted to check 👍🏻

@markmandel markmandel mentioned this pull request Oct 17, 2023
Open
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@XAMPPRocky XAMPPRocky enabled auto-merge (squash) February 12, 2024 09:29
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 40ea7f05-7b9f-42fe-849e-6ab27ef90e27

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/778/head:pr_778 && git checkout pr_778
cargo build

@XAMPPRocky XAMPPRocky merged commit b9b0237 into main Feb 27, 2024
5 checks passed
@markmandel markmandel deleted the ep/ue5-plugin branch February 28, 2024 07:31
markmandel
markmandel reviewed Feb 28, 2024
View reviewed changes
docs/src/sdks/unreal-engine.md

## How to install
To get this client proxy installed, the SDK should be located in `Engine` path for Plugins, so copy the whole `ue4` folder (resides under `sdks` folder) in your Unreal Engine path `/[UE4 Root]/Engine/Plugins`, then you may want to rename the ue4 folder to `Quilkin`. Unreal Engine will automatically discover the plugin by searching for `.uplugin` file.
{{#include ../../../sdks/ue5/README.md }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well isn't that clever 😄

@markmandel markmandel added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel left review comments

@koslib koslib koslib approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/feature New feature or request size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XAMPPRocky @markmandel @quilkin-bot @koslib