Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack around empty responses to relay #771

Closed
wants to merge 1 commit into from
Closed

Conversation

XAMPPRocky
Copy link
Collaborator

This shouldn't actually be merged, it's just a hack to help me debug, why the relay occasionally has empty endpoints despite the agent having a endpoint.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: f9840a2b-54b2-47c4-a050-093996fd62bc

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/771/head:pr_771 && git checkout pr_771
cargo build

@markmandel
Copy link
Member

So is that a "I should merge this" or "not merge this" 😁

@XAMPPRocky
Copy link
Collaborator Author

Don't merge, I just wanted a image to deploy and test with.

Though I would appreciate some help with writing an integration test for the relay, ones like what we have for the management server should be able to catch this, essentially like one in every ten requests from the relay is blank, so it leads to periods of stuttering from packets getting dropped from the relay sending the load balancer bad data.

@markmandel
Copy link
Member

Though I would appreciate some help with writing an integration test for the relay, ones like what we have for the management server should be able to catch this

Sounds good. Happy to write it or point you in the right directions.

If you want me to write it, I'd suggest writing up a quickstart, and I can use as the guide to make the integration test.

@XAMPPRocky
Copy link
Collaborator Author

If you want me to write it, I'd suggest writing up a quickstart, and I can use as the guide to make the integration test.

I mean, I'm not going to say no to that 😄

It's essentially the same as our current xds tests except for.

  • Spawn a relay agones server which has access the configmap for the load balancer.
  • Spawn an agent agones service with --relay set to the address of the relay server (port 7900)
  • Set the load balancer's --management-server address to the relay's address (port 7800)

For the test we should continually check that the load balancer has the matching gameserver address/token.

I'll write this up as an actual QuickStart guide tomorrow.

@markmandel
Copy link
Member

I mean, I'm not going to say no to that 😄

Works for me, since then I also get to learn how it all works too 😄

🤞🏻 I should wrap up #666 this week.

@XAMPPRocky XAMPPRocky closed this Aug 10, 2023
@XAMPPRocky
Copy link
Collaborator Author

superseded by #773

@markmandel markmandel deleted the ep/relay-hack branch September 20, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants