Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub's Changelog Generation #735

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind docum
entation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Remove ferrarimarco/github-changelog-generator as that was extremely flaky, and required some maintenance of secrets, and replace it with GitHub's automation.

Updated the release checklist as well to match.

Which issue(s) this PR fixes:

Work on #725

Special notes for your reviewer:

Snuck in a small typo on the release README.md as well.

Remove `ferrarimarco/github-changelog-generator` as that was extremely
flaky, and required some maintenance of secrets, and replace it with
GitHubs
automation.

Updated the release checklist as well to match.

Snuck in a small typo on the release README.md as well.

Work on googleforgames#725
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 13, 2023
@markmandel markmandel added this to the 0.6.0 milestone Apr 13, 2023
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 688d48c4-f149-4906-8845-1f18ca2309fc

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/735/head:pr_735 && git checkout pr_735
cargo build

@XAMPPRocky
Copy link
Collaborator

XAMPPRocky commented Apr 13, 2023

LGTM, also might want to look at release-plz which fully automates this, and makes a PR for the release that you can merge at anytime, I've started using it in my projects and it's been very helpful as now the only thing I have to do to make a release is to merge the PR. https://github.com/MarcoIeni/release-plz

Example: XAMPPRocky/octocrab#322

@XAMPPRocky XAMPPRocky merged commit 87e132b into googleforgames:main Apr 13, 2023
@markmandel markmandel deleted the release/switch-changelog branch April 18, 2023 08:36
@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants