-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pprof profiling endpoint #657
Conversation
Looks like a formatting issue, but otherwise should be fine. Also thinking because of this PR, we should get another release out this month. |
Yeah, though I need to make some changes as with the current implementation, we run out of memory pretty quickly right now, so I need to add some limits to stop that. |
Oops, that's no good 😄 I did have couple more thoughts this morning:
|
Just watching an amazing talk about continuous profiling at GDC -- rather than baking in profiling, instead we could look at a eBPF profiler such as https://pyroscope.io/ to run low overhead continuous profiling on both GameServers and Quilkin itself. I believe the only requirements are to have debug symbols (in some capacity) and frame pointers (I have not looked into details, just writing notes post talk). |
a45955d
to
d0cc316
Compare
Build Failed 😭 Build Id: d3507576-0196-4254-8ed6-ba1cd0acc82f Status: FAILURE To get permission to view the Cloud Build view, join the quilkin-discuss Google Group. Filter with the Git Commit Development images are retained for at least 30 days. |
Closed in favour of #875 |
This adds a proof profiling endpoint for Quilkin, allowing Quilkin to be continuously profiled using tools like Grafana Phlare.