Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pprof profiling endpoint #657

Closed
wants to merge 3 commits into from
Closed

Conversation

XAMPPRocky
Copy link
Collaborator

@XAMPPRocky XAMPPRocky commented Dec 5, 2022

This adds a proof profiling endpoint for Quilkin, allowing Quilkin to be continuously profiled using tools like Grafana Phlare.

@markmandel markmandel added kind/feature New feature or request area/operations Installation, updating, metrics etc labels Dec 6, 2022
@markmandel
Copy link
Member

Looks like a formatting issue, but otherwise should be fine.

Also thinking because of this PR, we should get another release out this month.

@XAMPPRocky
Copy link
Collaborator Author

Yeah, though I need to make some changes as with the current implementation, we run out of memory pretty quickly right now, so I need to add some limits to stop that.

@markmandel
Copy link
Member

Oops, that's no good 😄

I did have couple more thoughts this morning:

  1. Should we have some kind of admin option to turn this off?
  2. We should also document this somewhere 😁

@XAMPPRocky XAMPPRocky mentioned this pull request Mar 16, 2023
@markmandel
Copy link
Member

Just watching an amazing talk about continuous profiling at GDC -- rather than baking in profiling, instead we could look at a eBPF profiler such as https://pyroscope.io/ to run low overhead continuous profiling on both GameServers and Quilkin itself.

I believe the only requirements are to have debug symbols (in some capacity) and frame pointers (I have not looked into details, just writing notes post talk).

@quilkin-bot
Copy link
Collaborator

Build Failed 😭

Build Id: d3507576-0196-4254-8ed6-ba1cd0acc82f

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

Filter with the Git Commit 23c2a17 within us-docker.pkg.dev/quilkin/ci//quilkin to see if a development image is available from this build, and can be used for debugging purposes.

Development images are retained for at least 30 days.

@XAMPPRocky
Copy link
Collaborator Author

Closed in favour of #875

@XAMPPRocky XAMPPRocky closed this Feb 12, 2024
@markmandel markmandel deleted the ep/add-pprof-endpoint branch March 11, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/feature New feature or request size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants