Refactor metrics statics into free fns #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
markmandel
reviewed
Oct 26, 2022
| crate::metrics::PACKETS_DROPPED | ||
| .with_label_values(&[crate::metrics::READ_DIRECTION_LABEL, id]) | ||
| .inc(); | ||
| crate::metrics::packets_dropped(crate::metrics::READ, id).inc(); |
XAMPPRocky
force-pushed
the
ep/refactor-metrics
branch
from
0107e6d
to
f9a36f9
Compare
XAMPPRocky
force-pushed
the
ep/refactor-metrics
branch
from
f9a36f9
to
4dff181
Compare
|
Build Succeeded 🥳 Build Id: ce3b4ece-64d1-40be-9d25-43316e5a862e The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps a function around the metric static variables, this is to ensure at compile-time that all metrics always have the correct number of label values, previously there were one or two cases where one label was missing.