Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session should track Endpoint as destination #57

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

markmandel
Copy link
Member

Since data could come back to a Session that send data to an Endpoint, but from an address that isn't an Endpoint (not hugely likely, but possible), we should maintain the Endpoint with the Session, so we can eventually track this in our Filters.

Since data could come back to a Session that send data to an Endpoint,
but from an address that isn't an Endpoint (not hugely likely, but
possible), we should maintain the Endpoint with the Session, so we can
eventually track this in our Filters.
@markmandel markmandel added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels Jun 5, 2020
Copy link
Collaborator

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit 2c3742c into master Jun 5, 2020
@markmandel markmandel deleted the feature/session-dest branch June 5, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants