Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend fs::write test delay, and remove admin server from test to prevent flakiness #569

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

No description provided.

Copy link

@RominaMar RominaMar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 596a9a78-b5ae-42cb-a7a1-b49c2d380832

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/569/head:pr_569 && git checkout pr_569
cargo build

@XAMPPRocky XAMPPRocky merged commit 02f94d7 into main Aug 12, 2022
@XAMPPRocky XAMPPRocky deleted the fix-flakes branch August 12, 2022 11:31
XAMPPRocky added a commit that referenced this pull request Aug 22, 2022
XAMPPRocky added a commit that referenced this pull request Aug 22, 2022
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants