Only search for config file when required #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searching for the config file on every invocation of quilkin is not required. This is a small optimisation, but also solves the error of googleforgames#558 (although not the CI issue).
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh,
vallfors and
bombsimon
as code owners
XAMPPRocky
approved these changes
Aug 12, 2022
|
Build Succeeded 🥳 Build Id: 36bb1654-11e4-4e04-990e-75b4acdcc28f To build this version: |
XAMPPRocky
added a commit
that referenced
this pull request
Aug 22, 2022
Searching for the config file on every invocation of quilkin is not required. This is a small optimisation, but also solves the error of #558 (although not the CI issue). Co-authored-by: XAMPPRocky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Searching for the config file on every invocation of quilkin is not required.
This is a small optimisation, but also solves the error of #558
(although not the CI issue).
Which issue(s) this PR fixes:
Work on #558
Special notes for your reviewer:
Am looking into how to solve the CI issue seperately.