Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement xDS in Quilkin #552

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Implement xDS in Quilkin #552

merged 1 commit into from
Aug 3, 2022

Conversation

XAMPPRocky
Copy link
Collaborator

See #527 for details

@github-actions

This comment was marked as resolved.

Sign in to view
markmandel
markmandel reviewed Aug 2, 2022
View reviewed changes
about.toml Outdated Show resolved Hide resolved
build.rs Show resolved Hide resolved
src/config/slot.rs Outdated Show resolved Hide resolved
src/config/watch/agones/crd.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/filters/token_router.rs Outdated Show resolved Hide resolved
@markmandel
Copy link
Member

Taking a look through 👍🏻 will take another look through the final pieces shortly.

@XAMPPRocky XAMPPRocky force-pushed the ep/merged-changes branch 2 times, most recently from c5c2235 to e116439 Compare August 2, 2022 12:03
@googleforgames googleforgames deleted a comment from github-actions bot Aug 2, 2022
@googleforgames googleforgames deleted a comment from github-actions bot Aug 2, 2022
@googleforgames googleforgames deleted a comment from github-actions bot Aug 2, 2022
markmandel
markmandel reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished running through, just a couple of minor licence items, and the question about that metrics we are tracking for packets.

Once we resolve that, good to merge.

src/proxy/sessions/session.rs Outdated Show resolved Hide resolved
src/xds/resource.rs Show resolved Hide resolved
src/xds/server.rs Show resolved Hide resolved
@XAMPPRocky XAMPPRocky requested a review from vallfors as a code owner August 2, 2022 20:39
@googleforgames googleforgames deleted a comment from github-actions bot Aug 2, 2022
@googleforgames googleforgames deleted a comment from github-actions bot Aug 2, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0f2bf266-8774-4405-b532-8330d0fbd68a

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/552/head:pr_552 && git checkout pr_552
cargo build

@XAMPPRocky XAMPPRocky mentioned this pull request Aug 3, 2022
Closed
@markmandel markmandel mentioned this pull request Aug 3, 2022
Open
markmandel
markmandel approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@markmandel markmandel merged commit 4800db4 into main Aug 3, 2022
@markmandel markmandel deleted the ep/merged-changes branch August 3, 2022 21:09
@markmandel markmandel added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@luna-duclos luna-duclos Awaiting requested review from luna-duclos

@rezvaneh rezvaneh Awaiting requested review from rezvaneh

@bombsimon bombsimon Awaiting requested review from bombsimon

@vallfors vallfors Awaiting requested review from vallfors

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/feature New feature or request size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @markmandel @quilkin-bot