Remove cross from build tools #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By including a linker for windows and the corresponding toolchain, we can cross compile to Windows quite easily, and then we no longer need cross or Docker in Docker. (Hopefully) closes googleforgames#530
markmandel
added
kind/bug
markmandel
requested review from
XAMPPRocky,
luna-duclos,
rezvaneh and
bombsimon
as code owners
|
Build Succeeded 🥳 Build Id: 9d626f8e-8763-490f-8244-927e3e974132 To build this version: |
bombsimon
approved these changes
Jun 6, 2022
Awesome! I think it should also reduce CI and build times as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
By including a linker for windows and the corresponding toolchain, we can cross compile to Windows quite easily, and then we no longer need cross or Docker in Docker.
Which issue(s) this PR fixes:
(Hopefully) closes #530
Special notes for your reviewer:
@bombsimon if you get a chance to run this on WSL, I'd appreciate it!l