Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of local_receive_filter #53

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

markmandel
Copy link
Member

FilterChain for local_receive_filter is in place, and working as expected, with accompanying unit tests.

Found a small issue in Session as well that also got fixed in this PR that came up in the unit tests.

Work on #1

@markmandel markmandel added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels May 31, 2020
src/server/server.rs Outdated Show resolved Hide resolved
FilterChain for local_receive_filter is in place, and working as
expected, with accompanying unit tests.

Found a small issue in Session as well that also got fixed in this PR
that came up in the unit tests.

Work on #1
@markmandel markmandel force-pushed the feature/local_receive_filter branch from f6b2473 to 7b4c960 Compare June 1, 2020 03:33
Copy link
Collaborator

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit 0936dbe into master Jun 1, 2020
@markmandel markmandel deleted the feature/local_receive_filter branch June 1, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants