-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-generation of JSON schema. #478
Conversation
6a2d15e
to
02a17fe
Compare
02a17fe
to
5b57714
Compare
a4dfa77
to
b8dd915
Compare
This comment was marked as resolved.
This comment was marked as resolved.
[preprocessor.links] | ||
after = ["quilkin"] | ||
|
||
[preprocessor.quilkin] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is magic 🪄
eb1777f
to
a0423e1
Compare
b013ea1
to
73adf2b
Compare
372fd1d
to
959e98f
Compare
@markmandel Can't figure out the CI failure here. That (
|
Yeah, that's a weird one. Lemme take a peek, see what's up. |
Ah found it - if we look at the whole log, we see as:
Which is hidden at the step level. Cloud Build is set to 30m build time (at some point we should dig into why each step keeps re-downloading and compiling - thought that volume was shared between builds). I'll send a PR to bump it to 2h. |
26cf1df
to
81866eb
Compare
This commit adds support for Quilkin to generate JSON schema for any of the included filters, and adds some glue to make it so that these schemas are automatically included in the mdBook documentation.
81866eb
to
c6fc7de
Compare
Build Succeeded 🥳 Build Id: 5a0a3e96-5b48-4cc3-bb9f-9ccea390b299 To build this version:
|
This commit adds support for Quilkin to generate JSON schema for any of the included filters, and adds some glue to make it so that these schemas are automatically included in the mdBook documentation.
Additionally to work with mdbook, the
-q/--quiet
flag was added to run Quilkin in silent mode.There's still some improvements to be made for some of the special items, but this is already much better IMO than having to maintain these configurations by hand.
Breaking Changes
(these are mostly changes to better accept
config
now with the change to a derive macro for the CLI, which makes it easier to accept and validate types likePathBuf
)runner::run_with_config
has been removed andrunner::run
now accepts aConfig
argument.Config::find
has been removed and functionality has been moved into the binary directly. This is to make it easier to move the environment handling toclap
.--config
now comes before the command.config_schema
toFilterFactory
.