Documentation for Firewall filter #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/documentation
iffyio
approved these changes
Nov 4, 2021
While writing the docs, I found a typo in the name of the Filter, so included that as well. Closes googleforgames#158 Closes googleforgames#343
markmandel
force-pushed
the
docs/firewall-filter
branch
from
d7b4ebe to
7ea05a5
Compare
XAMPPRocky
reviewed
Nov 4, 2021
|
Build Succeeded 🥳 Build Id: d2dc9c7b-7d62-4296-82c3-75b1485ca191 To build this version: |
XAMPPRocky
approved these changes
Nov 5, 2021
markmandel
added a commit
to markmandel/quilkin
that referenced
this pull request
Nov 5, 2021
In googleforgames#432 we introduced having the documentation for a Filter have a openapi spec description, as well as a link to the Rust doc definition of its configuration. I liked it so much, I went and did it for the rest of the filters.
XAMPPRocky
pushed a commit
that referenced
this pull request
Nov 8, 2021
In #432 we introduced having the documentation for a Filter have a openapi spec description, as well as a link to the Rust doc definition of its configuration. I liked it so much, I went and did it for the rest of the filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Finishes off the Firewall Filter!
Which issue(s) this PR fixes:
Closes #158
Closes #343
Special notes for your reviewer:
While writing the docs, I found a typo in the name of the Filter, so
included that as well.