Hash load balancer

[gilesheron]

First cut of a hashed load-balancer for Quilkin so all requests from one session go to the same endpoint.

Note that hashes by source IP/port. Might be good to make it configurable.

Also doesn't implement a consistent hash (so if the set of endpoints changes all flows will re-hash).

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[markmandel]

Looks like your commits are using [email protected] right now, which hasn't signed the CLA.

If you rebase down to a single commit, and make sure to use your work email, we should be good to go 🤞🏻

[XAMPPRocky]

Thank you for your PR! This looks good to me, pretty nice solution. You mention it would be nice to add configuration, what would you want to configure about the hashing?

[gilesheron]

Thank you for your PR! This looks good to me, pretty nice solution. You mention it would be nice to add configuration, what would you want to configure about the hashing?

might be worth having an option to hash by source IP only if you want a mode where all sessions from a given user are routed to the same endpoint?

will re-submit as a single commit with the correct email address - once I work out how to do that!

[quilkin-bot]

Build Failed 😭

Build Id: c237ffad-373d-4a90-90d7-52dedefe1dce

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

[quilkin-bot]

Build Failed 😭

Build Id: c237ffad-373d-4a90-90d7-52dedefe1dce

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

[XAMPPRocky]

might be worth having an option to hash by source IP only if you want a mode where all sessions from a given user are routed to the same endpoint?

I might be missing something, but isn't that what setting HASH would do? Or are you suggesting having another option that remembers (ip, port) but doesn't hash?

[gilesheron]

might be worth having an option to hash by source IP only if you want a mode where all sessions from a given user are routed to the same endpoint?

I might be missing something, but isn't that what setting HASH would do? Or are you suggesting having another option that remembers (ip, port) but doesn't hash?

ah sorry. Didn't explain myself well.

the current solution hashes on the source SocketAddr. So all traffic from the same IP/port will go to the same endpoint. My guess is that for most games that will ensure that all of a given user's traffic will go to the same endpoint, whilst also giving optimal hashing if e.g. multiple users are behind a NAT, and ensuring that a user can reconnect and get a different endpoint if one endpoint has an issue.

the other approach would be to hash on source IpAddr. that way all traffic from given IP will go to one endpoint. So if a game has multiple flows per user that will ensure that they land on the same endpoint.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[quilkin-bot]

Build Failed 😭

Build Id: 99a55882-9bd7-4bd1-8214-f2c84aed316d

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[quilkin-bot]

Build Failed 😭

Build Id: 241eb6ec-7ed0-471f-ba03-96d02a50fdda

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

[quilkin-bot]

Build Succeeded 🥳

Build Id: 72940302-5709-4ea3-8fc1-5909d057d0ca

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/381/head:pr_381 && git checkout pr_381
cargo build

[iffyio]

LGTM! Thanks!

[markmandel]

We were tracking this on Discord, but @thisisnotapril is looking into what the situation is with the CLA.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[quilkin-bot]

Build Succeeded 🥳

Build Id: 4f900e4d-9246-41e4-9b11-76cc79b3ebb2

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/381/head:pr_381 && git checkout pr_381
cargo build

[markmandel]

Manual approval on the CLA - so merging 👍🏻