Add a type for session keys #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently looking at adding some sort of session based state in a filter and figured to make this a type rather than using a plain tuple of adresses so that its easier to identify across the repo
XAMPPRocky
approved these changes
Aug 12, 2021
|
actually scratch that, my use case (ratelimiting) doesn't need per session state since filters don't know what the destination address will be :P only the source will be sufficient, this is probably still a useful change though |
markmandel
approved these changes
Aug 12, 2021
markmandel
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently looking at adding some sort of session based state in a filter
and figured to make this a type rather than using a plain tuple of adresses so that
its easier to identify across the repo