Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make licence explicit in Cargo.toml #338

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

markmandel
Copy link
Member

Seems like crates.io thinks our licence is "non-standard", so switching license-file for license in the Cargo.toml.

image

Seems like crates.io thinks our licence is "non-standard", so switching
`license-file` for `license` in the Cargo.toml.
@markmandel markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: df9eb94e-bbd5-4095-969e-a35171b43048

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/338/head:pr_338 && git checkout pr_338
cargo build

@XAMPPRocky
Copy link
Collaborator

LGTM, though I'd also file an issue on the crates.io repository if there isn't one already, the licence-file option was added later so crates.io might not be accounting for it.

@markmandel
Copy link
Member Author

Excellent suggestion. Doing that now.
rust-lang/crates.io#3784

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 2e5bebd1-161c-4a7d-88cc-74574c56fdb7

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/338/head:pr_338 && git checkout pr_338
cargo build

@markmandel markmandel merged commit 5ee0aec into googleforgames:main Jul 19, 2021
@markmandel markmandel deleted the cleanup/license branch July 22, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/meta Organisational matters. e.g. Governance, release cycles, etc. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants