Clippy fixes #246
Merged
Clippy fixes #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
approved these changes
May 11, 2021
There was a problem hiding this comment.
LGTM! Yeah the compare_exchange lint at least I remember was from 1.51 since the nightly rustc we used for doc test started complaining a few weeks back. I think we can merge this even without the new rustc PR actually the current clippy should still be fine with the change
|
the current failure is cargo fmt |
Fixed, should be good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running clippy on
mainreturns couple warnings. This PR address those lints. I think this requires #247 to land first to pass CI.