Add dynamic proxy configuration #150
Conversation
Integrates the XDS client into the cluster manager Work on #10
| @@ -0,0 +1,29 @@ | |||
| # | |||
| # Copyright 2020 Google LLC All Rights Reserved. | |||
There was a problem hiding this comment.
Should we also add an entry to https://github.com/googleforgames/quilkin/blob/master/docs/proxy-configuration.md while we are at it in this PR?
(Also just noted this page is not referenced from the home page, but that's a separate issue)
There was a problem hiding this comment.
Yeah good catch, will fix!
| properties: | ||
| filter: | ||
| '$ref': '#/definitions/filterchain' | ||
| endpoints: | ||
| '$ref': '#/definitions/endpoints' | ||
| required: | ||
| - endpoints | ||
| dynamic: |
There was a problem hiding this comment.
Should this be a oneOf with children of dynamic and static ? https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/#oneof
Or would that be too complicated for the documentation? (Not for this PR, but maybe we should split this up into separate docs)
Actually, this would be the link of oneOf, yes? http://json-schema.org/draft-04/json-schema-validation.html#rfc.section.5.5 ?
There was a problem hiding this comment.
Yeah ideally it'll be oneof but oneof is a bit weird at the top level, instead of being able to say oneof static or dynamic at the top level, we can only say oneof or which might be more complex
There was a problem hiding this comment.
Sounds good - just wanted to check 👍
markmandel
added
kind/feature
Integrates the XDS client into the cluster manager
Work on #10