Add XDS client #115
Merged
Add XDS client #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a grpc client that can talk to an ADS server and forwards requests/responses from/to a cluster manager.
|
Just so I remember how xDS works -- the Quilkin Proxy will reach out to an xDS server through this client to get updates on the configuration state. Have I remembered that correctly? |
markmandel
reviewed
Oct 27, 2020
src/xds/ads_client.rs
Outdated
| /// sending summarized cluster updates on the provided channel. | ||
| pub async fn run( | ||
| self, | ||
| log: Logger, |
There was a problem hiding this comment.
I think I've been bad about enforcing this, but I like to have a source attribute for loggers, which you can see here:
quilkin/src/extensions/filters/debug.rs
Line 54 in 95cfb9d
So it is obvious in the logs where are coming from. Might even want to include the node_id?
markmandel
approved these changes
Oct 28, 2020
markmandel
added
area/operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a grpc client that can talk to an ADS server
and forwards requests/responses from/to a cluster manager.