Add test helper to manage test resources #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The test helper is used to create test resources and makes sure that those resources are cleaned up at the end of a test case. * Also updates tests to use the helper instead. Fixes #84
markmandel
added
area/tests
markmandel
approved these changes
Sep 17, 2020
| (local_addr, wait) | ||
| pub struct TestHelper { | ||
| pub log: Logger, | ||
| /// Channel to subscribe to, and trigger the shutdown of created resources. |
There was a problem hiding this comment.
We could replace server_shutdown_tx with shutdown_ch when that refactor of main.rs comes down the pipe, yeah?
There was a problem hiding this comment.
Yes we should be able to replace it after that lands!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes sure that those resources are cleaned up at the
end of a test case.
Fixes #84