Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should sender/receiver be client/server as concepts? #22

Closed
markmandel opened this issue Feb 3, 2020 · 2 comments · Fixed by #23
Closed

Should sender/receiver be client/server as concepts? #22

markmandel opened this issue Feb 3, 2020 · 2 comments · Fixed by #23
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc

Comments

@markmandel
Copy link
Member

Not sure if "sender" and "receiver" are good names as concepts.

Since the "sender" usually sits in front of a game client, and the "receiver" usually sits in front of a game server, we could rename this to being a "client proxy" rather than a "sender proxy" and a "server proxy" rather than a "receiver proxy"?

But the flip side is, sender/receiver do explain who starts the initial connection, so I'm not sure.

Throwing this out there for discussion. How do other people feel?
@markmandel markmandel added the area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc label Feb 3, 2020
@suom1
Copy link
Collaborator

suom1 commented Feb 3, 2020

I think client and server is better, mostly because they're more clear concepts for those who work with servers and infrastructure which is where these names will be referred.

@markmandel
Copy link
Member Author

The more I think on it, I think we're on the same page. I think we should make the change too.

markmandel added a commit that referenced this issue Feb 4, 2020
@markmandel
Rename sender/receiver to client/server
97842f7 
Changes the nomenclature to being "client proxy" and "server proxy",
which is far easier to understand, both from a user perspective, and
from a code perspective.

Closes #22
@markmandel markmandel mentioned this issue Feb 4, 2020
Merged
markmandel added a commit that referenced this issue Feb 4, 2020
@markmandel
Rename sender/receiver to client/server (#23)
6f90328 
Changes the nomenclature to being "client proxy" and "server proxy",
which is far easier to understand, both from a user perspective, and
from a code perspective.

Closes #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename sender/receiver to client/server googleforgames/quilkin
2 participants
@suom1 @markmandel