Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tracing propagation and service name prioritize envvar #427

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat: tracing propagation and service name prioritize envvar #427

merged 4 commits into from
Sep 19, 2023

Conversation

vasconcelosvcd
Copy link
Collaborator

What type of PR is this?
/kind feat

Which issue(s) this PR fixes:

Closes #426

Special notes for your reviewer:

ghost
ghost suggested changes Sep 18, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expose env var with viper, similar to what we have done with a Redis config.

internal/pkg/tracing/tracing.go Outdated Show resolved Hide resolved
ghost
ghost suggested changes Sep 18, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement for outdated comments.

configs/service.yaml Outdated Show resolved Hide resolved
internal/pkg/config/model.go Outdated Show resolved Hide resolved
ghost
ghost approved these changes Sep 19, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vasconcelosvcd vasconcelosvcd merged commit 1a2e694 into googleforgames:main Sep 19, 2023
4 checks passed
@vasconcelosvcd vasconcelosvcd deleted the issue-426-tracing branch September 19, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing requests: propagation and service name setting.
1 participant
@vasconcelosvcd