feat: get multi records by keys #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongalex
reviewed
Nov 7, 2022
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
ghost
changed the title
|
After talking with Alex, we agreed that using unary gRPC message would introduce less complexity and potentially less configuration / performance issues than opening many long lived streams (which by default are capped to 100 per server). |
ghost
marked this pull request as ready for review
hongalex
reviewed
Nov 10, 2022
|
Added some comments here and there. To me it looks like you only need |
yuryu
reviewed
Nov 10, 2022
hongalex
reviewed
Nov 15, 2022
vasconcelosvcd
approved these changes
Nov 16, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feat
What this PR does / Why we need it:
Performance optimization provided by a new endpoint to fetch records in batches by passing an array of keys.
Which issue(s) this PR fixes:
Closes #407
Special notes for your reviewer:
This new open saves interface leverage the GetMulti capabilities that was added to metaDB.