Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Checksums - add Checksums and Digest types #306

Merged
merged 5 commits into from
Sep 29, 2021

Conversation

yuryu
Copy link
Member

@yuryu yuryu commented Sep 28, 2021

What type of PR is this?
/kind feat

What this PR does / Why we need it:
Add Checksums and Digest types to manage blob checksums.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@yuryu yuryu self-assigned this Sep 28, 2021
@yuryu yuryu requested review from hongalex and a user September 28, 2021 00:12
@yuryu yuryu added this to the v0.2.0-beta3 milestone Sep 28, 2021
@yuryu yuryu changed the title feat: Checksums - add Checksums type feat: Checksums - add Checksums and Digest types Sep 28, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor update proposed on the interface to get CRC32 value.

internal/pkg/metadb/checksums/checksums.go Show resolved Hide resolved
@yuryu yuryu requested a review from a user September 28, 2021 22:54
@google-cla google-cla bot added the cla: yes label Sep 29, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuryu yuryu merged commit 99041ce into googleforgames:main Sep 29, 2021
@yuryu yuryu deleted the feat/checksums-type branch September 29, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant