feat(cache)!: add support for cache hints #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuryu
reviewed
Sep 30, 2020
yuryu
added a commit
to yuryu/open-saves
that referenced
this pull request
Jul 24, 2022
Deletes hint from QueryRecordsResponse. QueryRecordsResponse has a hint field but it should not have been there... Hints are something passed from the client not returned by the server. It's been around since googleforgames#123 but never been implemented.
yuryu
added a commit
that referenced
this pull request
Jul 28, 2022
Deletes hint from QueryRecordsResponse. QueryRecordsResponse has a hint field but it should not have been there... Hints are something passed from the client not returned by the server. It's been around since #123 but never been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feat
What this PR does / Why we need it:
Adds hints for how to use the cache.
Which issue(s) this PR fixes:
Closes #64
Special notes for your reviewer:
BREAKING CHANGE: this reworks the
Hintsfield in the proto for easier access. Previously, hints were accessed as an array of hints, but having them as individual fields is an improvement discussed in #64.