Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clean target for SDK conformance tests #997

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Aug 14, 2019

Need to have a predefined make target to clean output
after running SDK conformance tests.

For #996 .

Need to have a predefined make target to clean output
after running SDK conformance tests.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: be42e051-0990-4f26-9ff9-4e6ca8bb2eda

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Aug 14, 2019

New E2E test fail:

time="2019-08-14 09:27:05.499" level=info msg="Scaling fleet" fleet=scale-fleet-0-gq8tg scale=0
time="2019-08-14 09:27:06.099" level=info msg="fleet simple-fleet-btv77 has 2/0 ready replicas"
time="2019-08-14 09:27:07.318" level=info msg="fleet simple-fleet-km7c6 has 2/0 ready replicas"
--- FAIL: TestGameServerShutdown (81.60s)
gameserver_test.go:368: 
Error Trace:	gameserver_test.go:368
Error: Received unexpected error:
timed out waiting for the condition
Test: TestGameServerShutdown

@markmandel
Copy link
Member

Hit retry. TestGameServerShutdown is definitely showing up as the preeminent flaky test atm.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6796329c-e6b7-417a-a1f8-4f6fbf432d8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/997/head:pr_997 && git checkout pr_997
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-91420f2

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 14, 2019
@markmandel markmandel merged commit 3976519 into googleforgames:master Aug 14, 2019
@markmandel markmandel added this to the 1.0.0 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants