Local SDK Server: Add proper GS state handling #979

aLekSer · 2019-08-05T15:47:07Z

Update the state of local SDK GS according to calls which were made
by SDK client. Local sidecar now keeps track of the current state.
Part of #958 fix.
Added UTs for localsdk.go.

Need to add transition to Unhealthy state in a separate PR.

agones-bot · 2019-08-05T16:20:59Z

Build Succeeded 👏

Build Id: 054d7b89-2b94-4b1d-92e7-76daeb35b30e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-d381ebd
image: gcr.io/agones-images/agones-sdk:0.12.0-d381ebd
image: gcr.io/agones-images/agones-ping:0.12.0-d381ebd
Linux C++ SDK (build): agonessdk-0.12.0-d381ebd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-d381ebd.zip

A preview of the website (the last 30 builds are retained):

https://d381ebd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/979/head:pr_979 && git checkout pr_979
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-d381ebd

roberthbailey · 2019-08-06T04:07:47Z

Does this fix #958?

aLekSer · 2019-08-06T07:08:38Z

@roberthbailey Yes, it is but after a small update. I need to make validTransition() function consistent to state diagram:
https://development.agones.dev/site/docs/reference/gameserver/

agones-bot · 2019-08-06T13:32:55Z

Build Failed 😱

Build Id: 5c152218-0701-4ee2-9ce8-f441916bccf9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-06T13:36:24Z

Build Failed 😱

Build Id: dea6b858-c77c-4333-b73d-0243e79df781

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-06T14:11:34Z

Build Succeeded 👏

Build Id: f390bbff-34e0-4b6f-bcd2-46faff946c28

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-9f606ee
image: gcr.io/agones-images/agones-sdk:0.12.0-9f606ee
image: gcr.io/agones-images/agones-ping:0.12.0-9f606ee
Linux C++ SDK (build): agonessdk-0.12.0-9f606ee-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-9f606ee.zip

A preview of the website (the last 30 builds are retained):

https://9f606ee-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/979/head:pr_979 && git checkout pr_979
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-9f606ee

markmandel · 2019-08-14T16:47:19Z

pkg/sdkserver/localsdk.go

+	m[string(from)+string(to)] = true
+}
+
+func initValidStateTransitions() map[string]bool {


I'm wondering if we really care about this?

What are we trying to prevent here? I'm just wondering if this is going put some limitations on what's possible with the local test server, and add extra maintenance down the road for us.

What's the worst that happens if we don't validate state transitions locally?

Main intention was to prevent developers from using wrong assumptions while debugging their game servers locally.
Additionally this would be a place in go code where we state all possible edges of state diagram.
I imagine that we can add a flag to validate this transitions or not so that it would be optional.

I'm just trying to think of what could be a bad transition?

Moving from Shutdown -> Ready/Allocated/Reserved ?

Even then - I'm not sure if we should stop people. If the developer wants to go in that loop, they would have to restart the gameserver and sdk every time, and that could slow them down. Fast development iteration loops are a very good thing, so should we be putting extra friction in people's way?

If people really want to move from Shutdown -> Ready they can change the backing file anyway, and it (should) overwrite what's in the local sdk. So I'm not sure this is necessary?

Yes, that's right. This is redundant for local development and those steps are well documented in GS State transitions schema.

agones-bot · 2019-08-15T12:46:17Z

Build Failed 😱

Build Id: a3281ddb-136c-4549-999d-62751fd04cba

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Update the state of local SDK GS according to calls which were made by SDK client. Local sidecar now keeps the current state. For googleforgames#958.

agones-bot · 2019-08-15T12:48:12Z

Build Failed 😱

Build Id: b59d9a82-9bed-4509-9ac3-48fa6740cd6d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-15T13:01:02Z

Build Succeeded 👏

Build Id: c8126e79-49b0-4f0b-a746-fc701d9b7368

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-eaf292f
image: gcr.io/agones-images/agones-sdk:1.0.0-eaf292f
image: gcr.io/agones-images/agones-ping:1.0.0-eaf292f
Linux C++ SDK (build): agonessdk-1.0.0-eaf292f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-eaf292f.zip

A preview of the website (the last 30 builds are retained):

https://eaf292f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/979/head:pr_979 && git checkout pr_979
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-eaf292f

markmandel

Nice!

agones-bot · 2019-08-15T19:08:18Z

Build Failed 😱

Build Id: 41db2b40-6085-4afa-8b63-edf97272f3c0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-15T19:29:54Z

Build Succeeded 👏

Build Id: 71570bf9-d7a7-4655-9505-4e314c76d78e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-73e61a8
image: gcr.io/agones-images/agones-sdk:1.0.0-73e61a8
image: gcr.io/agones-images/agones-ping:1.0.0-73e61a8
Linux C++ SDK (build): agonessdk-1.0.0-73e61a8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-73e61a8.zip

A preview of the website (the last 30 builds are retained):

https://73e61a8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/979/head:pr_979 && git checkout pr_979
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-73e61a8

aLekSer force-pushed the local-sdk-server-updates branch 2 times, most recently from 89df81b to 74e0d3f Compare August 6, 2019 13:28

aLekSer force-pushed the local-sdk-server-updates branch from 74e0d3f to 9f606ee Compare August 6, 2019 13:38

aLekSer marked this pull request as ready for review August 6, 2019 14:16

markmandel reviewed Aug 14, 2019

View reviewed changes

aLekSer force-pushed the local-sdk-server-updates branch 2 times, most recently from 5ce1b2c to 22ca271 Compare August 15, 2019 12:43

Adding proper GS state handling for local SDK

eaf292f

Update the state of local SDK GS according to calls which were made by SDK client. Local sidecar now keeps the current state. For googleforgames#958.

aLekSer force-pushed the local-sdk-server-updates branch from 22ca271 to eaf292f Compare August 15, 2019 12:47

markmandel approved these changes Aug 15, 2019

View reviewed changes

Merge branch 'master' into local-sdk-server-updates

73e61a8

markmandel merged commit 6aab022 into googleforgames:master Aug 15, 2019

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Aug 15, 2019

markmandel added this to the 1.0 milestone Aug 15, 2019

aLekSer deleted the local-sdk-server-updates branch August 15, 2019 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local SDK Server: Add proper GS state handling #979

Local SDK Server: Add proper GS state handling #979

aLekSer commented Aug 5, 2019 •

edited

Loading

agones-bot commented Aug 5, 2019

roberthbailey commented Aug 6, 2019

aLekSer commented Aug 6, 2019 •

edited

Loading

agones-bot commented Aug 6, 2019

agones-bot commented Aug 6, 2019

agones-bot commented Aug 6, 2019

markmandel Aug 14, 2019

aLekSer Aug 14, 2019

markmandel Aug 14, 2019

aLekSer Aug 15, 2019

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

markmandel left a comment

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

Local SDK Server: Add proper GS state handling #979

Local SDK Server: Add proper GS state handling #979

Conversation

aLekSer commented Aug 5, 2019 • edited Loading

agones-bot commented Aug 5, 2019

roberthbailey commented Aug 6, 2019

aLekSer commented Aug 6, 2019 • edited Loading

agones-bot commented Aug 6, 2019

agones-bot commented Aug 6, 2019

agones-bot commented Aug 6, 2019

markmandel Aug 14, 2019

Choose a reason for hiding this comment

aLekSer Aug 14, 2019

Choose a reason for hiding this comment

markmandel Aug 14, 2019

Choose a reason for hiding this comment

aLekSer Aug 15, 2019

Choose a reason for hiding this comment

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

aLekSer commented Aug 5, 2019 •

edited

Loading

aLekSer commented Aug 6, 2019 •

edited

Loading