Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS EKS cluster creating docs #965

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jul 30, 2019

All comments regarding CNI is outdated, resulting cluster would have
version of CNI 1.5 which is bigger than 1.2 required.

Part of #717.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 30, 2019

Well I have not configured valid email for git on new device

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@roberthbailey
Copy link
Member

Please use the {{% feature expiryVersion="0.12.0" %}} and {{% feature publishVersion="0.12.0" %}} blocks to wrap the changes so that they go live with the 0.12.0 release instead of immediately.

See https://agones.dev/site/docs/contribute/

All comments regarding CNI is outdated, resulting cluster would have
version of CNI 1.5 which is bigger than 1.2 required.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 33e3945e-46e2-4aba-9966-830de8526733

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/965/head:pr_965 && git checkout pr_965
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-91ac798

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 57ffeec7-d948-4dd4-aa4b-4103ece42d3a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/965/head:pr_965 && git checkout pr_965
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-ab3925c

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b80c0d29-c63a-45e1-b65a-0fd7bbab42d2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/965/head:pr_965 && git checkout pr_965
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-56e5539

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a76d0031-a610-450f-ae84-611541e079b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/965/head:pr_965 && git checkout pr_965
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-a014640

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fc719ae4-504d-444d-bc7d-76198ba79dc6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/965/head:pr_965 && git checkout pr_965
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-4e71374

@roberthbailey roberthbailey merged commit ae1f88a into googleforgames:master Jul 30, 2019
@aLekSer aLekSer deleted the fix/eks-docs branch July 30, 2019 20:05
@markmandel markmandel added this to the 0.12.0 milestone Aug 1, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants