Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gameserver status subresource #947

Closed
wants to merge 1 commit into from
Closed

Gameserver status subresource #947

wants to merge 1 commit into from

Conversation

markmandel
Copy link
Member

This is a draft implementation. I'm not convinced this is a good idea
as it removes the essentially atomic/transactional nature of being able
to manipulate GameServer resources -- which because of Allocation, is
something that is ideal to have.

I expect that e2e tests will fail.

@markmandel
Gameserver status subresource
fdab91e 
This is a draft implementation. I'm not convinced this is a good idea
as it removes the essentially atomic/transactional nature of being able
to manipulate GameServer resources -- which because of Allocation, is
something that is ideal to have.

I expect that e2e tests will fail.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change labels Jul 25, 2019
@markmandel markmandel mentioned this pull request Jul 25, 2019
Closed
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 36db7507-7cb5-4c2f-b3f0-4966875ca714

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/947/head:pr_947 && git checkout pr_947
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-fdab91e

@markmandel
Copy link
Member Author

I did not expect that to pass. Colour me surprised.

Humble 🍰

@markmandel
Copy link
Member Author

Closing this PR in favour of #959 - see #329 for details.

@markmandel markmandel closed this Jul 30, 2019
@markmandel markmandel deleted the feature/gameserver-subresource branch July 30, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markmandel @agones-bot