Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the create webhook fleetautoscaler guide. #931

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Updates to the create webhook fleetautoscaler guide. #931

merged 1 commit into from
Jul 22, 2019

Conversation

roberthbailey
Copy link
Member

Part of #703.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4826dcca-99e1-47a9-8ca8-0df75c703197

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/931/head:pr_931 && git checkout pr_931
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-844e63d

markmandel
markmandel approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit around "pod" - but change as you see fit. Otherwise, LGTM. Merge when ready.

site/content/en/docs/Getting Started/create-webhook-fleetautoscaler.md Show resolved Hide resolved
site/content/en/docs/Getting Started/create-webhook-fleetautoscaler.md Outdated Show resolved Hide resolved
site/content/en/docs/Getting Started/create-webhook-fleetautoscaler.md Outdated Show resolved Hide resolved
@roberthbailey roberthbailey force-pushed the autoscaler-service-example branch from 844e63d to 5c10a61 Compare July 22, 2019 07:42
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c5ba36ab-1670-4dc6-8a19-2df568283e75

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/931/head:pr_931 && git checkout pr_931
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-5c10a61

@roberthbailey roberthbailey merged commit 40343c9 into googleforgames:master Jul 22, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 26, 2019
Closed
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Aug 1, 2019
@roberthbailey roberthbailey deleted the autoscaler-service-example branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberthbailey @agones-bot @markmandel