Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update K8s Code Generation Tooling to 1.12 #928

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Update K8s Code Generation Tooling to 1.12 #928

merged 1 commit into from
Jul 19, 2019

Conversation

markmandel
Copy link
Member

Also regenerated the CRD clients with the updated tooling.

Needed to build a udp-server:0.14

Work for #717

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Jul 19, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d6016d5f-a51a-4c74-b936-1d45b0650e65

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/928/head:pr_928 && git checkout pr_928
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0dfb132

roberthbailey
roberthbailey approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Feel free to fix or ignore and then merge.

build/build-image/Dockerfile Outdated
chmod go+rx ./kubectl && \
mv ./kubectl /usr/local/bin/kubectl
RUN echo "source <(kubectl completion bash)" >> /root/.bashrc

# install the release branch of the code generator tools
RUN mkdir -p /go/src && cd /go/src && mkdir -p k8s.io && cd k8s.io && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize it was written this way before, but I don't understand the multiple mkdir commands, mkdir -p will create intermediate directories so a single mkdir -p /go/src/k8s.io && cd /go/src/k8s.io \ should do the trick.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh! Good point. I'll make this change and then merge.

@roberthbailey roberthbailey self-assigned this Jul 19, 2019
This was referenced Jul 19, 2019
Closed
Merged
Merged
@markmandel markmandel force-pushed the upgrade/k8s-code-gen branch from 0dfb132 to 783cb43 Compare July 19, 2019 22:20
@markmandel
Update K8s Code Generation Tooling to 1.12
6433823 
Also regenerated the CRD clients with the updated tooling.

Needed to build a udp-server:0.14

Work for googleforgames#717
@markmandel markmandel force-pushed the upgrade/k8s-code-gen branch from 783cb43 to 6433823 Compare July 19, 2019 23:04
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 603c13d8-368d-4e47-abfc-371cb0f657d2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/928/head:pr_928 && git checkout pr_928
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-6433823

@markmandel markmandel merged commit 8fb815a into googleforgames:master Jul 19, 2019
@markmandel markmandel deleted the upgrade/k8s-code-gen branch July 19, 2019 23:57
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @roberthbailey