Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions about taints and tolerations to the install instructions #870

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Add instructions about taints and tolerations to the install instructions #870

merged 1 commit into from
Jul 3, 2019

Conversation

roberthbailey
Copy link
Member

And a specific example for GKE. Remove some of the duplicate verbiage from the Helm instructions.

Ref: #491

@roberthbailey
Copy link
Member Author

/cc @markmandel

I'm not sure how to verify if I made the relative link correctly locally.

@markmandel
Copy link
Member

Looks like updates need to be made to for the website: https://github.com/googleforgames/agones/blob/master/build/README.md

make site-server will start the local server, so you can see what is happening.

If you want to run the site tests make site-test to run them locally.

@markmandel
Copy link
Member

We also have some docs instructions here: https://agones.dev/site/docs/contribute/

Which is actually a better spot to be updated.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: de4f1ec7-817d-44b9-af69-de5f63040342

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/870/head:pr_870 && git checkout pr_870
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bb505a1

@roberthbailey
Add instructions about taints and tolerations to the install instruct…
79b1b53 
…ions,

with a specific example for GKE. Remove some of the duplicate verbiage
from the Helm instructions.
@roberthbailey roberthbailey force-pushed the taints-and-tolerations branch from bb505a1 to 79b1b53 Compare July 3, 2019 18:29
markmandel
markmandel approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏇

@roberthbailey
Copy link
Member Author

$ make site-test
xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun

@roberthbailey
Copy link
Member Author

Seems like I need to look into that a bit more....

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c1a2718e-74ae-4584-bd71-2def8c031cbe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/870/head:pr_870 && git checkout pr_870
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-79b1b53

@markmandel markmandel merged commit e621065 into googleforgames:master Jul 3, 2019
@roberthbailey
Copy link
Member Author

Looks like I somehow borked my xcode install, which I'm in the process of fixing. It should be easier to verify the next one.

@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones kind/documentation Documentation for Agones labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/operations Installation, updating, metrics etc kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberthbailey @markmandel @agones-bot