Flaky: TestGameServerPassthroughPort #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/bug
|
Build Failed 😱 Build Id: 4017335e-d2dd-4662-b51c-5df732a442f5 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
TestGameServerPassthroughPort exposed a pretty nasty race condition in the sdk sidecar server, in which a request for GameServer information could come in just before it had cached its details, resulting in a "Not found" response. This uses a WaitGroup to requests for GameServer information until such time as it is initially loaded.
markmandel
force-pushed
the
flaky/TestGameServerPassthroughPort
branch
from
b76f7c8 to
a07843a
Compare
|
Build Succeeded 👏 Build Id: 30072d38-3134-46d7-8b37-870c225891fa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
cyriltovena
reviewed
Jul 4, 2019
| @@ -70,6 +70,7 @@ var ( | |||
|
|
|||
| // SDKServer is a gRPC server, that is meant to be a sidecar | |||
| // for a GameServer that will update the game server status on SDK requests | |||
| // nolint: maligned | |||
|
Build Succeeded 👏 Build Id: 4740c516-ffef-4413-b7fc-db7774da834a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestGameServerPassthroughPort exposed a pretty nasty race condition in the sdk sidecar server, in which a request for GameServer information could come in just before it had cached its details, resulting in a
"Not found" response.
This uses a WaitGroup to requests for GameServer information until such time as it is initially loaded.