Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle delete events when caching Ready GameServers for Allocation #815

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Handle delete events when caching Ready GameServers for Allocation #815

merged 2 commits into from
Jun 7, 2019

Conversation

markmandel
Copy link
Member

No description provided.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 6, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2c43c512-c3fe-4d70-97c9-8b5016153bb1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer
aLekSer reviewed Jun 6, 2019
View reviewed changes
pkg/gameserverallocations/controller.go Outdated
return
}
if newGs.IsBeingDeleted() {
// TOXO: test this
Copy link
Collaborator

@aLekSer aLekSer Jun 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are probably redundant.
Why TOXO, not TODO? Is it an abbreviation or just to distinguish from TODO?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4bcda7ed-d9ae-4813-bbdb-fe1cae7335c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/815/head:pr_815 && git checkout pr_815
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-0be6b15

@markmandel
Copy link
Member Author

Whoops! That's my personal "TODO" list for while I'm working, that is easy to filter on. I forgot to remove them 🤦‍♂️

@markmandel markmandel force-pushed the cleanup/cache-removal branch from 0be6b15 to fcfba6d Compare June 6, 2019 22:08
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 60d2426f-ebbc-48c4-a553-f4266b668bdb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/815/head:pr_815 && git checkout pr_815
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-fcfba6d

ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel added this to the 0.11.0 milestone Jun 7, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d40e70aa-0ff1-4e43-8109-0fab431d539d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/815/head:pr_815 && git checkout pr_815
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-a7b1909

@markmandel markmandel merged commit 19c8814 into googleforgames:master Jun 7, 2019
@markmandel markmandel deleted the cleanup/cache-removal branch June 7, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer left review comments

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @aLekSer @ilkercelikyilmaz