Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env namespace dependency from allocator service. #814

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Jun 6, 2019

issue #809

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7fd6c7b0-a29b-41c7-8b31-e2c05b81cea3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cmd/allocator/main.go Outdated Show resolved Hide resolved
@pooneh-m pooneh-m force-pushed the allocation branch 2 times, most recently from 7189d26 to 7072852 Compare June 6, 2019 17:42
@googleforgames googleforgames deleted a comment from agones-bot Jun 6, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1882d22b-5176-4677-95cb-77d3c8995dfa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-7072852

cmd/allocator/main.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a6d052cc-0b41-4d13-bf61-6cf1c7b25ce2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-0e67722

@@ -80,7 +83,9 @@ func TestAllocator(t *testing.T) {
response, err = client.Post(requestURL, "application/json", bytes.NewBuffer(body))

if err != nil {
response.Body.Close() // nolint: errcheck
if response != nil {
response.Body.Close() // nolint: errcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Small Go gotcha. response.Body.Close() should always get run if the response not nil. Usually defer is a nice way to do it.

Details, and examples: https://stackoverflow.com/questions/33238518/what-could-happen-if-i-dont-close-response-body-in-golang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response.Body.Close() is happening after the poll. So this one was not necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Nice!

@pooneh-m pooneh-m force-pushed the allocation branch 2 times, most recently from f1be9f6 to c59120a Compare June 7, 2019 00:44
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9f43c177-0f81-4dff-8b85-9fb320896ee6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c63f1750-3b8b-4b8b-92c6-58532e467466

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-e4f1c33

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 awesome.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c5cc0c4d-ebdf-406c-a0c1-d74fa0b830f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eae0f125-3e73-4168-8e16-d148e2cfe4e3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 28372f6b-c81b-4206-a607-75bfadd850ca

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 7, 2019
@markmandel
Copy link
Member

So this is consistently failing on this flaky test:

--- FAIL: TestAutoscalerWebhook (88.75s)
    fleetautoscaler_test.go:326: 
        	Error Trace:	fleetautoscaler_test.go:326
        	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"Operation cannot be fulfilled on fleetautoscalers.stable.agones.dev \"simple-fleet-vc2z8-autoscaler\": the object has been modified; please apply your changes to the latest version and try again", Reason:"Conflict", Details:(*v1.StatusDetails)(0xc000992600), Code:409}}
        	Test:       	TestAutoscalerWebhook

I'll rerun this once #812 has been merged. That should solve this problem and let this pass.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 097ac65f-379c-4b7d-ac6f-0ad47ea7e336

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-9b9837f

@markmandel markmandel merged commit bcb0c85 into googleforgames:master Jun 7, 2019
@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants