Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing apiGroup field in gameserver-allocator ServiceAccount role binding #811

Conversation

structurefall
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 053e3a71-4d77-4cb3-8776-847710d7fe9a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

/cc @pooneh-m for visibility

I believe this is to solve the issue you had when trying to install via install.yaml (which didn't work anyway, because master is always broken, since it's development)

error: error validating "agones-install.yaml": error validating data: ValidationError(RoleBinding.roleRef): missing required field "apiGroup" in io.k8s.api.rbac.v1.RoleRef; if you choose to ignore these errors, turn validation off with --validate=false

Change will need to be made in the relevant helm template, then run make gen-install to generate the install.yaml

@structurefall what Kubernetes version was this error received on?

@markmandel markmandel added kind/bug These are bugs. area/operations Installation, updating, metrics etc labels Jun 5, 2019
@pooneh-m
Copy link
Contributor

@structurefall thanks for the fix. I can get this checked in to get you unblocked until you have the CLA.

@pooneh-m
Copy link
Contributor

#825

@pooneh-m pooneh-m closed this Jun 12, 2019
@markmandel markmandel added the wontfix Sorry, but we're not going to do that. label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/bug These are bugs. wontfix Sorry, but we're not going to do that.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants