Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in URL #702

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Fixed typo in URL #702

merged 2 commits into from
Apr 12, 2019

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Apr 11, 2019 •
edited
Loading

This change is Reviewable

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4820f562-a808-44ba-9514-86fffacc1e1c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@devjgm
Copy link
Contributor Author

devjgm commented Apr 11, 2019

I'm pretty sure this breakage is unrelated to this PR, but I'm new to this codebase :-)

markmandel
markmandel approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Yep, result of a flaky test. Will rerun and this can go through!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ac771bab-dde9-46de-82fe-603f2c4ac945

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/702/head:pr_702 && git checkout pr_702
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-6b8a1d8

@markmandel markmandel merged commit 2dad5fd into googleforgames:master Apr 12, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 12, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Apr 12, 2019
@devjgm devjgm deleted the patch-1 branch April 15, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@devjgm @agones-bot @markmandel