Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency to util/runtime from APIS package #697

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Remove dependency to util/runtime from APIS package #697

merged 1 commit into from
Apr 9, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Apr 9, 2019

pkg/apis has an unnecessary dependency to pkg/util/runtime.
Removed the dependency to avoid needing to pull runtime imports just to reference apis package externally.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0408080c-a573-4395-b099-5969052be82e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f10b8cb9-8a6d-4911-850f-724b4bd76ff9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/697/head:pr_697 && git checkout pr_697
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e99cd34

2 similar comments
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f10b8cb9-8a6d-4911-850f-724b4bd76ff9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/697/head:pr_697 && git checkout pr_697
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e99cd34

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f10b8cb9-8a6d-4911-850f-724b4bd76ff9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/697/head:pr_697 && git checkout pr_697
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e99cd34

@jkowalski jkowalski merged commit 5ecb1a3 into googleforgames:master Apr 9, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 27, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowalski jkowalski jkowalski approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pooneh-m @agones-bot @jkowalski @markmandel