Lightweight library for implementing APIServer extensions #659
Conversation
|
Build Succeeded 👏 Build Id: 8bd41393-a3f2-446c-b5cf-a6e98062233d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
It will likely make things easier to review, but here is a (slightly out of date) example - https://github.com/markmandel/agones/blob/feature/gsa-api-server/pkg/gameserverallocations/controller.go#L104 So you can see how the pieces end up fitting together. (I need to update this to use go.mod instead as well) |
markmandel
added
the
feature-freeze-do-not-merge
|
Another thing but I'm ok with it, I don't think https is a good package name I understand why but I would prefer that you named it http and import it as https. |
The other API extension libraries were too opinionated, or not flexible enough to provide exactly what we need -- register a single verb in the API, not have storage, give full control over the http lifecycle. This provides just enough functionality for what we need, while also providing extension points in case we need to expand the API surface area in the future - such as a more explict OpenAPI spec. This is the foundational work that is required for converting GameServerAllocations into an API Extension - next step will be to use this library to implement that functionality.
markmandel
force-pushed
the
feature/apiserver
branch
from
9a9b93b to
1063c63
Compare
So, since we control the entire HTTP response - all HTTP verbs will be passed down to the Handler - then it's up to the handler to decide what to do with them. For example, we do this here: https://github.com/markmandel/agones/blob/feature/gsa-api-server/pkg/gameserverallocations/controller.go#L153-L157 So I guess we already support all of them? 😄
As you may have guessed, this server has to be https, so it felt like https was a good package name. Maybe it should just be something more like |
|
Build Succeeded 👏 Build Id: 16616f39-92ec-492f-aea7-2df53260e5e3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
let's keep it like this, may be later we will have a better view. |
|
Build Succeeded 👏 Build Id: 5b8c4217-0900-440b-b229-a8f0da6141ae The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
removed
the
feature-freeze-do-not-merge
The other API extension libraries were too opinionated, or not flexible enough to provide exactly what we need -- register a single noun in the API, not have storage, give full control over the http lifecycle.
This provides just enough functionality for what we need, while also providing extension points in case we need to expand the API surface area in the future - such as a more explict OpenAPI spec.
This is the foundational work that is required for converting GameServerAllocations into an API Extension - next step will be to use this library to implement that functionality.