Fix feature shortcode for Hugo #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: 311a060e-858b-4e4f-a73f-2e1e689c1939 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
aLekSer
force-pushed
the
fix/feature-shortcode
branch
from
d356422 to
6f8ae99
Compare
|
By default if we access element over the list length we would get 0 - and this would make shortcode work even for |
|
Build Succeeded 👏 Build Id: ba1e0851-a3d2-496d-afb9-e88ab6229b60 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
aLekSer
force-pushed
the
fix/feature-shortcode
branch
from
6f8ae99 to
74dd7e4
Compare
|
Build Succeeded 👏 Build Id: ebfa7498-112b-4fcf-aa1f-5219bcad8812 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Algorithm for splitting string by dots and comparing major, minor version one by one separately. There is no break statement for range loop, that's why added special handling for that case.
aLekSer
force-pushed
the
fix/feature-shortcode
branch
from
74dd7e4 to
02356ab
Compare
|
Build Succeeded 👏 Build Id: 550b10f9-0d42-46c1-afa8-b4ee5bf408f5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added
area/site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algorithm for splitting version strings by dots and comparing major, minor versions one by one separately. There is no break statement for range loop in Hugo functions, that's why added special handling for that case.
Closes #650 .