Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraed go-lint tooling. #612

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Upgraed go-lint tooling. #612

merged 2 commits into from
Feb 22, 2019

Conversation

markmandel
Copy link
Member

Fixes a strange linter panic in #600

Also found a small fix.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Feb 21, 2019
@markmandel markmandel added this to the 0.9.0 milestone Feb 21, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c81057e5-5146-49e6-b0af-e9a8eb3f3fba

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/612/head:pr_612 && git checkout pr_612
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-d898ead

cyriltovena
cyriltovena approved these changes Feb 22, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f673215b-f413-4ae8-bff9-8dfe4a269d21

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/612/head:pr_612 && git checkout pr_612
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-b3f1765

@markmandel markmandel merged commit 97f1935 into googleforgames:master Feb 22, 2019
@markmandel markmandel deleted the upgrade/linter branch February 22, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena