Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in SDK.SetLabel and SDK.SetAnnotation (issue #455) #584

Closed
wants to merge 0 commits into from

Conversation

Yingxin-Jiang
Copy link
Contributor

@Yingxin-Jiang Yingxin-Jiang commented Feb 11, 2019

Fix #455.

When synchronizing GameServer with requested operations, i.e. updateState, updateLabel, updateAnnotation, change the key format from {operation}/{data} to {operation}. The operation data is persisted in SDKServer, to prevent old operation data from overwriting the new one,

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bf0e6e9b-3069-4e30-9c92-ccc1627e182f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 68aa9232-93f4-4cd2-bc83-57b409deb59d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Meta comment: In the future, can we please get PR titles that are descriptive - it's much faster to parse and then prioritise that way.

@Yingxin-Jiang Yingxin-Jiang changed the title Issue 455 Fix race condition in SDK.SetLabel and SDK.SetAnnotation (issue #455) Feb 11, 2019
@Yingxin-Jiang
Copy link
Contributor Author

Meta comment: In the future, can we please get PR titles that are descriptive - it's much faster to parse and then prioritise that way.

Sure, good point. I updated this PR title and will use descriptive ones in the future.

The PR was originally sent out with the default title, which I should have paid attention to.

@jkowalski
Copy link
Contributor

can you squish your commits into one, please?

@Yingxin-Jiang
Copy link
Contributor Author

can you squish your commits into one, please?

Yes, will do. Learning how to :)

@markmandel
Copy link
Member

Nice approach! 💯

@markmandel markmandel added kind/bug These are bugs. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 12, 2019
@Yingxin-Jiang
Copy link
Contributor Author

Created another PR, #588. Close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants